Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made some custom transport implementation possible #59

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sum-catnip
Copy link

Hey,

im using your library at work and i needed to make it linux compatible. I made some very minor changes that allowed me to make my own RpcConnectedClientTransport implementation. The changes made it possible to use the SMBLibrary as my transport method instead of the pinvoke/windows-dependant one. If you don't mind, it would be nice to have those changes in the main repo so:

  1. others may benefit from making their own transport implementation
  2. i don't have to maintain my own fork :p

Have a nice day :)
Also thanks so much for creating this awesome project!

@google-cla
Copy link

google-cla bot commented Aug 11, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@sum-catnip
Copy link
Author

normally id publish the whole "linux implementation" but i only did the bare minimum as quickly as possible. Basically i just replaced the entire connect and bind part of this library with using SMBLibrary to connect and bind to a namedpipe. Then just used the pipes read and writefile functions for readfragment and writefragment. Thats i, but it works surprisingly well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant