Skip to content

Commit

Permalink
fix: remove DOUBLE reference which is SQLAlchemy 2.0-only
Browse files Browse the repository at this point in the history
  • Loading branch information
olavloite committed Dec 2, 2024
1 parent 6ddad5f commit 8d6da40
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 12 deletions.
3 changes: 0 additions & 3 deletions google/cloud/sqlalchemy_spanner/sqlalchemy_spanner.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,6 @@ def reset_connection(dbapi_conn, connection_record, reset_state=None):
"DATE": types.DATE,
"DATETIME": types.DATETIME,
"FLOAT32": types.REAL,
# Note: FLOAT64 was mapped to Float when Spanner only supported FLOAT64
# This should however rather have been types.Double.
"FLOAT64": types.Float,
"INT64": types.BIGINT,
"NUMERIC": types.NUMERIC(precision=38, scale=9),
Expand All @@ -106,7 +104,6 @@ def reset_connection(dbapi_conn, connection_record, reset_state=None):
types.DATETIME: "DATETIME",
types.REAL: "FLOAT32",
types.Float: "FLOAT64",
types.DOUBLE: "FLOAT64",
types.BIGINT: "INT64",
types.DECIMAL: "NUMERIC",
types.String: "STRING",
Expand Down
9 changes: 0 additions & 9 deletions test/mockserver_tests/test_float32.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,32 +12,23 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from google.cloud.spanner_admin_database_v1 import UpdateDatabaseDdlRequest
from sqlalchemy import create_engine, select, MetaData, Table, Column, Integer, String
from sqlalchemy.orm import Session
from sqlalchemy.testing import (
eq_,
is_instance_of,
is_not_none,
is_none,
is_false,
is_true,
)
from google.cloud.spanner_v1 import (
FixedSizePool,
BatchCreateSessionsRequest,
ExecuteSqlRequest,
ResultSet,
PingingPool,
ResultSetStats,
BeginTransactionRequest,
ExecuteBatchDmlRequest,
CommitRequest,
TypeCode,
)
from test.mockserver_tests.mock_server_test_base import (
MockServerTestBase,
add_select1_result,
add_result,
)

Expand Down

0 comments on commit 8d6da40

Please sign in to comment.