Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update dependency com.google.protobuf:protobuf-java to v3.25.5 [security] #2017

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Sep 19, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.google.protobuf:protobuf-java (source) 3.21.12 -> 3.25.5 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-7254

Summary

When parsing unknown fields in the Protobuf Java Lite and Full library, a maliciously crafted message can cause a StackOverflow error and lead to a program crash.

Reporter: Alexis Challande, Trail of Bits Ecosystem Security Team [email protected]

Affected versions: This issue affects all versions of both the Java full and lite Protobuf runtimes, as well as Protobuf for Kotlin and JRuby, which themselves use the Java Protobuf runtime.

Severity

CVE-2024-7254 High CVSS4.0 Score 8.7 (NOTE: there may be a delay in publication)
This is a potential Denial of Service. Parsing nested groups as unknown fields with DiscardUnknownFieldsParser or Java Protobuf Lite parser, or against Protobuf map fields, creates unbounded recursions that can be abused by an attacker.

Proof of Concept

For reproduction details, please refer to the unit tests (Protobuf Java LiteTest and CodedInputStreamTest) that identify the specific inputs that exercise this parsing weakness.

Remediation and Mitigation

We have been working diligently to address this issue and have released a mitigation that is available now. Please update to the latest available versions of the following packages:

  • protobuf-java (3.25.5, 4.27.5, 4.28.2)
  • protobuf-javalite (3.25.5, 4.27.5, 4.28.2)
  • protobuf-kotlin (3.25.5, 4.27.5, 4.28.2)
  • protobuf-kotlin-lite (3.25.5, 4.27.5, 4.28.2)
  • com-protobuf [JRuby gem only] (3.25.5, 4.27.5, 4.28.2)

Release Notes

protocolbuffers/protobuf (com.google.protobuf:protobuf-java)

v3.25.5

v3.25.4

v3.25.3

v3.25.2

v3.25.1

Compare Source

v3.25.0

Compare Source

v3.24.4

Compare Source

v3.24.3

Compare Source

v3.24.2

Compare Source

v3.24.1

Compare Source

v3.24.0

Compare Source

v3.23.4

Compare Source

v3.23.3

Compare Source

v3.23.2

Compare Source

v3.23.1

v3.23.0

Compare Source

v3.22.5

Compare Source

v3.22.4

Compare Source

v3.22.3

v3.22.2

Compare Source

v3.22.1

Compare Source

v3.22.0

Compare Source


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate-bot renovate-bot requested a review from a team as a code owner September 19, 2024 17:25
@dpebot
Copy link

dpebot commented Sep 19, 2024

/gcbrun

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Sep 19, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 19, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 19, 2024
@zhumin8
Copy link
Contributor

zhumin8 commented Oct 2, 2024

failing java 7 compatibility:

java.lang.UnsupportedClassVersionError: com/google/protobuf/MessageOrBuilder : Unsupported major.minor version 52.0
	at com.google.api.client.protobuf.ProtocolBuffersTest.testParseAndClose(ProtocolBuffersTest.java:29)

This is failing with Guava:

java.lang.Exception: Guava will drop support for Java 7 in 2021. Please let us know if this will cause you problems: https://github.com/google/guava/issues/5269
	at com.google.common.base.Preconditions.<clinit>(Preconditions.java:1498)

guava version upgrade (#1997) is also blocked by java 7 support.

@renovate-bot renovate-bot force-pushed the renovate/maven-com.google.protobuf-protobuf-java-vulnerability branch from 147eb83 to e5fea46 Compare November 19, 2024 20:51
@dpebot
Copy link

dpebot commented Nov 19, 2024

/gcbrun

@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2024
@renovate-bot renovate-bot force-pushed the renovate/maven-com.google.protobuf-protobuf-java-vulnerability branch from e5fea46 to 91c61ea Compare November 19, 2024 20:59
@dpebot
Copy link

dpebot commented Nov 19, 2024

/gcbrun

@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants