Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): add support for cross-package references #7792

Merged
merged 6 commits into from
Nov 6, 2024
Merged

feat(docs): add support for cross-package references #7792

merged 6 commits into from
Nov 6, 2024

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Nov 1, 2024 •
edited
Loading

b/374863204

  • traverses all files to determine their protobuf packages
  • maps these to the namespace rules defined in composer.json for PSR-4
  • caches them because this is expensive to do

@bshaffer bshaffer marked this pull request as ready for review November 1, 2024 23:08
@bshaffer bshaffer requested review from a team as code owners November 1, 2024 23:08
@bshaffer bshaffer mentioned this pull request Nov 4, 2024
Merged
6 tasks
@bshaffer bshaffer added the next release PRs to be included in the next release label Nov 4, 2024
@bshaffer bshaffer merged commit 7d368c2 into main Nov 6, 2024
28 checks passed
@bshaffer bshaffer deleted the fix-cross-package-references branch November 6, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hectorhammett Hectorhammett Hectorhammett approved these changes

Assignees
No one assigned
Labels
next release PRs to be included in the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bshaffer @Hectorhammett