feat(tests): organize workflows, add system tests #7695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hectorhammett
approved these changes
Sep 27, 2024
| @@ -212,6 +213,9 @@ public static function generatedSystemTestBootstrap() | |||
| // For generated system tests, we need to set GOOGLE_APPLICATION_CREDENTIALS | |||
| // and PROJECT_ID to appropriate values | |||
| $keyFilePath = getenv('GOOGLE_CLOUD_PHP_TESTS_KEY_PATH'); | |||
| if (empty($keyFilePath)) { | |||
| exit('GOOGLE_CLOUD_PHP_TESTS_KEY_PATH must be set to run system tests.'); | |||
There was a problem hiding this comment.
Nit:
Should we place this as a constant somewhere? I see that this env is used in several places. I think if this code needs maintenance it would be easier to have all of the places using one constant and easy to change in one place rather than using a string.
There was a problem hiding this comment.
Yes absolutely. I've added your suggestion (and some of my own) in this issue so that we can clean this part up soon
| $keyFilePath = getenv('GOOGLE_CLOUD_PHP_TESTS_KEY_PATH'); | ||
| $keyFileData = json_decode(file_get_contents($keyFilePath), true); | ||
| $projectId = $keyFileData['project_id']; |
There was a problem hiding this comment.
json_decode can return false, should we check for it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
system-tests.yamlworkflow has passed, but it's being skipped in this PR.