Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GTFS Trip-Modifications #403
GTFS Trip-Modifications #403
Changes from 8 commits
b2bfcf5
ab5e996
7887381
da1c109
52d4064
c2f88a0
9a0d6d5
7a67845
364e32b
f3944b0
8533985
121049c
4b90e8a
7ef14f5
8f5d394
0126942
429c56b
e0b0f48
14e4259
36f3cac
b92a5b2
fb9c8df
b5f65bf
f26ded5
5e6f44c
a91db62
47a3ceb
99aba67
c4e94d9
437fc84
ae77b32
1c54a21
be4a9c6
51980b8
5afb5de
2721fe0
a1e4af7
19b4d2e
37f290d
418702a
b437508
4be2666
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I think you are using tab indentation in a few place here where the rest of the file uses spaces? I know it's petty to complain about whitespace in a code-review, but it's making it hard to look at the delta in Github because the indentation is weird 😇 Both here and below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. The indentation looks strange in Github.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fact that the comment uses both the terms "stops" and "stop times", which already have defined meanings in GTFS, to refer to the same thing (a field and message type called
replacement_stops
) is confusing, requiring the reader to dig into the ReplacementStop message and discover that it provides information allowing the consumer to synthesize new stop times by adding delays to existing scheduled stop_times, referencing existing or newly created stops. I'd recommend revising terminology for consistency - readers will perceive terms to mean what they've been defined to mean within GTFS. Or at least rephrase the comment to explain more clearly.