Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add gofuzz tags to build #10884

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Conversation

arirubinstein
Copy link
Contributor

It appears that gofuzz was removed from the default tagspec in the main branch of go-118-fuzz-build 1 to gofuzz_libfuzzer and libfuzzer. To keep compatibility with the go build scripts, this change adds the gofuzz tag to the go-118-fuzz-build invocation.

Footnotes

  1. https://github.com/AdamKorcz/go-118-fuzz-build/pull/9/files#diff-2873f79a86c0d8b3335cd7731b0ecf7dd4301eb19a82ef7a1cba7589b5252261L35

@oliverchang
Copy link
Collaborator

@AdamKorcz can you please help with reviewing this?

Copy link
Collaborator

@AdamKorcz AdamKorcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@DonggeLiu
Copy link
Contributor

/gcbrun skip

@DonggeLiu DonggeLiu merged commit ce908a4 into google:master Aug 29, 2023
19 checks passed
jonathanmetzman pushed a commit that referenced this pull request Sep 5, 2023
Add the tagspec to the coverage build as well to include the correct
files.

ref: #10884
gedigi pushed a commit to gedigi/oss-fuzz that referenced this pull request Sep 27, 2023
Add the tagspec to the coverage build as well to include the correct
files.

ref: google#10884
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants