Remove HWY_CONTRIB_DLLEXPORT from definition of function #2255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @xiaozhuai , just to confirm: is the error still happening in MSVC? |
No, it has been fixed in #2229. But it's not include in latest 1.2.0. |
|
Got it, thanks. We might do another release in a few weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HWY_CONTRIB_DLLEXPORTare already set correctly in the declaration. There is no need to dup it on definition of function. Which cause an error on msvcerror C2491: 'hwy::GetThreadAffinity': definition of dllimport function not allowed