RNS: allow mod arith types as basis types #1114
Open
+105
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZenithalHourlyRate
force-pushed
the
rns-modarith
branch
from
29a26c1
to
14300e1
Compare
j2kun
approved these changes
Nov 24, 2024
| // ----- | ||
|
|
||
| // expected-error@+1 {{does not have RNSBasisTypeInterface}} | ||
| !ty_int_bad = !rns.rns<i32, i64> |
There was a problem hiding this comment.
Please add a test where it succeeds as well.
There was a problem hiding this comment.
I think there is no case for i32 to pass the check?
There was a problem hiding this comment.
Sorry, I meant for mod_arith types. All tests added in this PR, even for mod arith, check error cases.
There was a problem hiding this comment.
Added a succeeding case for storage type check.
ZenithalHourlyRate
force-pushed
the
rns-modarith
branch
from
14300e1
to
a79b227
Compare
ZenithalHourlyRate
force-pushed
the
rns-modarith
branch
from
a79b227
to
7607e28
Compare
j2kun
approved these changes
Nov 24, 2024
j2kun
added
the
pull_ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1098
As the coprime relationship is not associative, the description is changed accordingly.