This repository has been archived by the owner on Feb 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 660
Fix segmentations failure in error.c gumbo_caret_diagnostic_to_string #371
Open
DmitryBochkarev
wants to merge
1
commit into
google:master
Choose a base branch
from
DmitryBochkarev:segmentation_failure_fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
#include "gumbo.h" | ||
#include "parser.h" | ||
#include "error.h" | ||
|
||
#include <string> | ||
|
||
#include "gtest/gtest.h" | ||
#include "test_utils.h" | ||
|
||
namespace { | ||
|
||
class GumboErrorTest : public ::testing::Test { | ||
protected: | ||
GumboErrorTest() {} | ||
|
||
virtual ~GumboErrorTest() { | ||
|
||
} | ||
}; | ||
|
||
TEST_F(GumboErrorTest, NewlineAfterLessThanSymbol) { | ||
const GumboOptions *options = &kGumboDefaultOptions; | ||
const char *input = "<\n"; | ||
size_t input_len = strlen(input); | ||
GumboOutput *output = gumbo_parse_with_options(options, input, input_len); | ||
GumboVector *errors = &output->errors; | ||
GumboParser parser = { ._options = options }; | ||
GumboStringBuffer msg; | ||
|
||
gumbo_string_buffer_init(&parser, &msg); | ||
for (size_t i=0; i < errors->length; i++) { | ||
GumboError *err = (GumboError *)errors->data[i]; | ||
gumbo_string_buffer_clear(&parser, &msg); | ||
gumbo_caret_diagnostic_to_string(&parser, err, input, &msg); | ||
} | ||
gumbo_string_buffer_destroy(&parser, &msg); | ||
|
||
gumbo_destroy_output(options, output); | ||
} | ||
|
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this actually the correct fix? If
*error_location
is\n
, shouldn't this move to the previous\n
(if any)? For example, given the source text"<\n"
, that line is the one with the error. With your patch, wouldn'toriginal_line
ingumbo_caret_diagnostic_to_string()
point to the new line and have length 0?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you're right. Actually i did not care about error message and did not thinking about that. But i think that is are edge case and handling of that case should be done in caller function.