Remove allowInterop calls, fix types of callbacks, and use dart:js_interop #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terop TokenClientConfig, CodeClientConfig, and revoke all take Dart functions only and therefore we should not use allowInterop. Fixes the type expected by revoke to take a JS value that is compatible with the callback. Also removes uses of dart:js in favor of dart:js_interop.
kevmoo
approved these changes
Nov 7, 2024
kevmoo
reviewed
Nov 7, 2024
kevmoo
reviewed
Nov 7, 2024
|
Thanks!
I went ahead and added a changelog to reduce the churn. Let me know if that works! |
|
I'm so confused...huh? |
Which part? I removed that changelog entry because it's wrong - this only partially migrates to |
|
Ah! okay... |
|
FYI @stereotype441 this has landed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TokenClientConfig, CodeClientConfig, and revoke all take Dart functions only and therefore we should not use allowInterop. Fixes the type expected by revoke to take a JS value that is compatible with the callback. Also removes uses of dart:js in favor of dart:js_interop.