-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gcbrun trigger #1898
Fix gcbrun trigger #1898
Conversation
/gcbrun run_experiment.py -a --experiment-config /opt/fuzzbench/service/experiment-config.yaml --experiment-name 2023-09-06-fix-gcb --fuzzers afl --benchmark libxml2_xml |
Testing launching exp with the comment above, will test some other cases once it launches successfully. |
Experiment |
This comment should not trigger any experiment now. |
The comment still triggers the GCB, but did not attempt to start an experiment because of this fix. It returns None and prints It would be great if we could simply ignore the GCB command, but that is controlled by GCB trigger, not our script. |
/gcbrun run_experiment.py -a --experiment-config /opt/fuzzbench/service/experiment-config.yaml --experiment-name 2023-09-06-fix-gcb-1 --fuzzers afl --benchmark libxml2_xml |
Experiment |
/gcbrun run_experiment.py -a --experiment-config /opt/fuzzbench/service/experiment-config.yaml --experiment-name 2023-09-06-fix-gcb-2 --fuzzers afl --benchmark libxml2_xml |
Experiment |
/gcbrun run_experiment.py -a --experiment-config /opt/fuzzbench/service/experiment-config.yaml --experiment-name 2023-09-06-fix-gcb-2 --fuzzers afl --benchmark libxml2_xml |
/gcbrun run_experiment.py -a --experiment-config /opt/fuzzbench/service/experiment-config.yaml --experiment-name 2023-09-06-fix-gcb-2 --fuzzers afl --benchmark libxml2_xml |
This should not start an exp. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Fixes #1897