Update documentation #1533
Closed
Update documentation #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonggeLiu
commented
Oct 20, 2022
| @@ -258,7 +258,7 @@ Building benchmarks and fuzzers entails the following process: | |||
| image. This is the first image in this build process that is defined by the | |||
| main FuzzBench code (e.g. not fuzzers, benchmarks, or OSS-Fuzz). Its first | |||
| function is to copy the FuzzBench code and install packages needed to run | |||
| FuzzBench like Python3.7 For benchmarks that define a `commit` in their | |||
| FuzzBench like Python3.10. For benchmarks that define a `commit` in their | |||
There was a problem hiding this comment.
I am not sure if I understand this sentence:
- The original text said
3.7. I guess this is a legacy typo, as I thought the currentFuzzBenchrequires3.8at minimum? - Do we really need to install python in
docker/benchmark-builder/Dockerfile? For example, I remove the python installation indocker/benchmark-builder/Dockerfilein Upgrade base images, benchmark images, and Python. #1526, and it still seems to be able to buildlibpng-1.2.56withlibfuzzer.
There was a problem hiding this comment.
- Yes.
- We should so that there is a consistent python version used throughout the project.
There was a problem hiding this comment.
Cool, I will add back the python installation steps.
There was a problem hiding this comment.
Done in commit Install Python3.10 in BenchmarkBuilder.
jonathanmetzman
approved these changes
Oct 20, 2022
Good point, thanks! |
|
Merged into #1526. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.