Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ubuntu to jammy and python to 3.10 #1521

Closed
wants to merge 8 commits into from

Conversation

DonggeLiu
Copy link
Contributor

  1. Updates Python to 3.10,
  2. Updates Pip packages that require a newer version to work under Python-3.10,
  3. Updates Ubuntu to 22.04 (Jammy Jellyfish),
  4. Fix all errors/warnings caused by using outdated packages.

@DonggeLiu DonggeLiu changed the title Update ubuntu python Update ubuntu to jammy and python to 3.10 Oct 12, 2022
@DonggeLiu
Copy link
Contributor Author

Not sure if this is a good idea, but I updated Ubuntu to 22.04 (Jammy Jellyfish) instead of 20.04 (Focal Fossa) (which is planned), because:

  1. We want Python-3.10, which is the default in 22.04 but not in 20.04;
  2. The default Python-3.10 in 20.04 works smoothly with the current code, while the Python-3.10 I built manually in 20.04 caused a few errors (which should be solvable).
  3. Both 22.04 and. 20.04 are fully supported, 22.04 will last longer.

@DonggeLiu DonggeLiu marked this pull request as draft October 12, 2022 08:19
@jonathanmetzman
Copy link
Contributor

Sorry Dongge, I don't think we want to upgrade to Jammy. We should upgrade to focal.

@jonathanmetzman
Copy link
Contributor

We should just build Python from source if we need a certain version.
Maybe you can take over this PR https://github.com/google/fuzzbench/pull/1441/files btw

@DonggeLiu
Copy link
Contributor Author

Sorry Dongge, I don't think we want to upgrade to Jammy. We should upgrade to focal.

OK, I will stick to focal, then : )
Would you mind explaining a bit more to me about why would we prefer focal over jammy?
Is it because focal has been released for a while and is more widely supported, or because we want to make it consistent with OSS-Fuzz?
Thanks!

@jonathanmetzman
Copy link
Contributor

Sorry Dongge, I don't think we want to upgrade to Jammy. We should upgrade to focal.

OK, I will stick to focal, then : ) Would you mind explaining a bit more to me about why would we prefer focal over jammy? Is it because focal has been released for a while and is more widely supported, or because we want to make it consistent with OSS-Fuzz? Thanks!

It's to be consistent with oss-fuzz yeah. That's where most of our benchmarks come from. That's also the platform we care most about (e.g. if centipede worked on jammy but not focal, it would be useless to us).

@DonggeLiu
Copy link
Contributor Author

Sorry Dongge, I don't think we want to upgrade to Jammy. We should upgrade to focal.

OK, I will stick to focal, then : ) Would you mind explaining a bit more to me about why would we prefer focal over jammy? Is it because focal has been released for a while and is more widely supported, or because we want to make it consistent with OSS-Fuzz? Thanks!

It's to be consistent with oss-fuzz yeah. That's where most of our benchmarks come from. That's also the platform we care most about (e.g. if centipede worked on jammy but not focal, it would be useless to us).

I see : ) Thanks!
I will make use of the PR you shared and (hopefully) make it ready by today : )

@jonathanmetzman
Copy link
Contributor

Sorry Dongge, I don't think we want to upgrade to Jammy. We should upgrade to focal.

OK, I will stick to focal, then : ) Would you mind explaining a bit more to me about why would we prefer focal over jammy? Is it because focal has been released for a while and is more widely supported, or because we want to make it consistent with OSS-Fuzz? Thanks!

It's to be consistent with oss-fuzz yeah. That's where most of our benchmarks come from. That's also the platform we care most about (e.g. if centipede worked on jammy but not focal, it would be useless to us).

I see : ) Thanks! I will make use of the PR you shared and (hopefully) make it ready by today : )

I think we will need to just junk some bug benchmarks.

@DonggeLiu
Copy link
Contributor Author

Sorry Dongge, I don't think we want to upgrade to Jammy. We should upgrade to focal.

OK, I will stick to focal, then : ) Would you mind explaining a bit more to me about why would we prefer focal over jammy? Is it because focal has been released for a while and is more widely supported, or because we want to make it consistent with OSS-Fuzz? Thanks!

It's to be consistent with oss-fuzz yeah. That's where most of our benchmarks come from. That's also the platform we care most about (e.g. if centipede worked on jammy but not focal, it would be useless to us).

I see : ) Thanks! I will make use of the PR you shared and (hopefully) make it ready by today : )

I think we will need to just junk some bug benchmarks.

Yep! I recall you mentioned having another FuzzBench2.0 and stop supporting some benchmarks.
I will pay attention to that and list the benchmarks that appear to be buggy.

@jonathanmetzman
Copy link
Contributor

Sorry Dongge, I don't think we want to upgrade to Jammy. We should upgrade to focal.

OK, I will stick to focal, then : ) Would you mind explaining a bit more to me about why would we prefer focal over jammy? Is it because focal has been released for a while and is more widely supported, or because we want to make it consistent with OSS-Fuzz? Thanks!

It's to be consistent with oss-fuzz yeah. That's where most of our benchmarks come from. That's also the platform we care most about (e.g. if centipede worked on jammy but not focal, it would be useless to us).

I see : ) Thanks! I will make use of the PR you shared and (hopefully) make it ready by today : )

I think we will need to just junk some bug benchmarks.

Yep! I recall you mentioned having another FuzzBench2.0 and stop supporting some benchmarks. I will pay attention to that and list the benchmarks that appear to be buggy.

to be clear, I mean the benchmarks that are used to benchmark bug finding ability.

@jonathanmetzman
Copy link
Contributor

but yeah these will be buggy too :-)

@DonggeLiu
Copy link
Contributor Author

We solve this in #1526 : )

@DonggeLiu DonggeLiu closed this Dec 5, 2022
@jonathanmetzman jonathanmetzman deleted the update_ubuntu_python branch December 5, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants