Fix benchmark integration script #1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @maxammann |
Closed
|
This is blocking #1441 |
maxammann
approved these changes
Sep 29, 2022
|
Like you said in Discord: It might be a good idea to remove this script. Most of the time this will not easily work. And frankly, without understanding what is going on, how benchmarks are built, which tools they use, just copying it is very dangerous. I think it would be good to "force" users going the more complicated way of manually creating a new benchmark. |
oliverchang
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous model used a submodule that was never updated and thus the stuff copied from oss-fuzz repo was very old and generally not working. Change this to use the latest oss-fuzz clone.