Upgrade to python3.10 #1493
Closed
Upgrade to python3.10 #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanmetzman
force-pushed
the
fuzzbench-clean
branch
from
7a7d5d1 to
32d5271
Compare
|
CC @andreafioraldi Fixes #1490 |
|
Well I'm trying to build python3.10 and now it can't use SSL. I wonder if Ubuntu 16 is tool old to build 3.10. May need to wait on: #1441 |
oliverchang
approved these changes
Sep 28, 2022
There was a problem hiding this comment.
LGTM, but should we also updated https://google.github.io/fuzzbench/getting-started/prerequisites/#python-programming-language ?
| @@ -241,14 +241,12 @@ def pytype(paths: List[Path]) -> bool: | |||
| """Run pytype on |path| if it is a python file. Return False if it fails | |||
| type checking.""" | |||
| paths = [path for path in paths if is_python(path)] | |||
| if not paths: | |||
There was a problem hiding this comment.
Is this (and the print below) an intentional change?
There was a problem hiding this comment.
Yeah. We don't need this early bail out. The print wasn't intended though.
DonggeLiu
added a commit
that referenced
this pull request
Oct 19, 2022
|
This is included in #1526 : ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.