Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chilled Beams #725

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Chilled Beams #725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b631f16
Chilled beam addition
nwssullivan Jul 25, 2022
720c997
Chilled beams
nwssullivan Jul 25, 2022
df0f9e9
Chilled beams
nwssullivan Jul 25, 2022
42573fe
chilled beams
nwssullivan Jul 25, 2022
3a1e0ef
Update telemetry_fields.yaml
nwssullivan Aug 19, 2022
aadf2b1
Update ABSTRACT.yaml
nwssullivan Aug 19, 2022
4d9b66b
Update CHB.yaml
nwssullivan Aug 19, 2022
5be5dda
Update ABSTRACT.yaml
nwssullivan Aug 19, 2022
c0b7366
Merge branch 'master' into patch-1
cstirdivant Aug 19, 2022
963d91c
Merge branch 'master' into patch-1
cstirdivant Nov 21, 2022
f516cff
Merge branch 'master' into patch-1
cstirdivant Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6859,6 +6859,46 @@ RDC:
implements:
- MONITORING

CHWZOUC:
description: "Chilled water valve control with occupied/unoccupied setpoints and temperature monitoring."
is_abstract: true
opt_uses:
- chilled_supply_water_temperature_sensor
uses:
- chilled_water_valve_percentage_command
- zone_air_temperature_sensor
- zone_air_occupied_temperature_setpoint
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of odd seeing occupied temp setpoint and unoccupied cooling setpoint. shouldnt they both be cooling setpoints?

- zone_air_unoccupied_cooling_temperature_setpoint
implements:
- CONTROL

PERHWZOUC:
description: "Perimeter heating water valve control with occupied/unoccupied setpoints and temperature monitoring."
is_abstract: true
opt_uses:
- perimeter_heating_supply_water_temperature_sensor
- perimeter_heating_water_valve_percentage_sensor
uses:
- perimeter_heating_water_valve_percentage_command
- zone_air_temperature_sensor
- zone_air_occupied_temperature_setpoint
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as above, except heating. id expect these to match.

- zone_air_unoccupied_heating_temperature_setpoint
implements:
- CONTROL

ZTOUC:
description: "Zone air temperature unoccupied/occupied control."
is_abstract: true
opt_uses:
- zone_air_relative_humidity_sensor
- zone_occupancy_status
uses:
- zone_air_temperature_sensor
- zone_air_occupied_temperature_setpoint
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its odd to me that you have differentiated heating and cooling setpoints for unoccupied times, but there are no equivalent differentiations for occupied setpoints.

in general, we see either a single setpoint that changes based on mode, or we see two effective setpoints (for cooling and for heating) that change based on occ/unocc status. what is the context for this weird configuration?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were no heating/cooling setpoints for occupied mode. Unit runs in either cooling or heating mode while zone is occupied and controls to the occupied setpoint. In unoccupied mode the heating/cooling valves modulate to maintain the zone between the unoccupied heating/cooling setpoints.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be fixed? this inconsistency between control in occupied and unoccupied mode is highly irregular.

otherwise, these will need to be modeled separately (e.g. zone temp and occ setpoint together in one abstract type, and zone temp and unoccupied setpoints together in another -- then a single type can implement both pieces of functionality in some non-canonical way, since this is very irregular).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this pretty frequently in terminal units where there is a single setpoint during occupied hours, but during unoccupied hours there is a night setback for both heating and cooling. Do they need to be separated into separate abstract types?

- zone_air_unoccupied_heating_temperature_setpoint
- zone_air_unoccupied_cooling_temperature_setpoint
implements:
- OPERATIONAL

RFSS:
guid: "2ca79174-7d36-4341-a820-0db83cd9470c"
Expand Down
28 changes: 28 additions & 0 deletions ontology/yaml/resources/HVAC/entity_types/CHB.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
# Copyright 2020 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the License);
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# https://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an AS IS BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

########################
### Canonical Types ###
########################

CHB_ZTOUC_CHWZOUC_PERHWZOUC_CO2M_RMM:
description: "Chilled beam with perimeter heating, CO2 and run mode monitoring."
is_canonical: true
implements:
- CHB
- ZTOUC
- CHWZOUC
- PERHWZOUC
- CO2M
- RMM
6 changes: 6 additions & 0 deletions ontology/yaml/resources/HVAC/entity_types/GENERALTYPES.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,6 +424,12 @@ CRREF:
implements:
- EQUIPMENT

CHB:
description: "Tag for chilled beams."
is_abstract: true
implements:
- EQUIPMENT

WSHP:
guid: "55c3b629-1018-462d-9e23-fd56a38743ec"
description: "Tag for water source heat pumps.WSHP serves as a heating or cooling system using water as a heat exchange medium. In contrast to chillers that centralize cooling production and distribute chilled water, WSHPs operate locally, offering isolated control by using water from a nearby source for both heating and cooling functions within a building."
Expand Down
32 changes: 32 additions & 0 deletions ontology/yaml/resources/fields/telemetry_fields.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2909,6 +2909,38 @@ literals:
- exhaust_fan_speed_mode:
- BYPASS
- VFD

## New fields for EM##
- electricalgrid_energy_accumulator
- generator_run_time_accumulator
- generator_energy_accumulator
- electricalgrid_run_time_accumulator

## New fields for fans##
- discharge_fan_energy_accumulator
- supply_fan_energy_accumulator
- compressor_run_time_accumulator

- total_lamp_failed_counter
- total_wireless_device_failed_counter
- total_communication_failed_counter

## New fields for seismic detector
- seismic_alarm

## New fields for chilled beams
- zone_air_occupied_temperature_setpoint
- zone_air_unoccupied_cooling_temperature_setpoint
- perimeter_heating_water_valve_percentage_sensor
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this ever exist independently of another valve?

if we know the device lives on a perimeter then would heating_water_valve_percentage_... be sufficient?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially there could be other heating valves, like reheat or four pipe chilled beams.

- perimeter_heating_water_valve_percentage_command
- perimeter_heating_supply_water_temperature_sensor

## New fields for RO water system
- water_totaldissolvedsolids_concentration_sensor

## New field for SDC
- shade_extent_percentage_sensor

- electricalgrid_energy_accumulator:
fixed_min: 0.0
flexible_max: 4000000.0
Expand Down
1 change: 1 addition & 0 deletions ontology/yaml/resources/subfields/subfields.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@ descriptor:
ozone: "Highly reactive gaseous compound comprised of three oxygen atoms."
particle: "A very fine clump of solid matter."
outside: "Process or measurement of local atmospheric conditions."
perimeter: "The outermost parts or boundary of an area or object (e.g. a zone)"
phase: "A phase of three-phase power distribution systems."
phase1: "The first (nominally A) phase of three-phase power distribution systems."
phase2: "The second (nominally B) phase of three-phase power distribution systems."
Expand Down
Loading