Heat recovery unit #1048
Heat recovery unit #1048
Conversation
There was a problem hiding this comment.
Some questions about the configuration and control of this particular device. Please provide comments on how the device controls so we can better advise on how to proceed with the modeling.
If you have any questions or want to provide us with some schematic of the system to help explain it to us, please contact: [email protected]. Happy to set up some time to discuss as well, if that will expedite the process.
| @@ -6618,3 +6618,48 @@ VMADC: | |||
| - mixed_air_damper_percentage_sensor | |||
| implements: | |||
| - CONTROL | |||
|
|
|||
| RSM: | |||
There was a problem hiding this comment.
Why not use SS and mark the field run_command as missing? It seems this is not doing anything different than SS, its just that the field for the command doesnt exist or can't be passed to cloud.
| implements: | ||
| - OPERATIONAL | ||
|
|
||
| SEFC: |
There was a problem hiding this comment.
I dont see supply_air_flowrate_sensor or exhaust_air_flowrate_sensor. Those fields need to be added if this device controls the fan speeds to maintain flowrates to a setpoint.
Secondly, this type could be avoided if you instead apply the types SFVSC, EFVSC, SFC, and EFC. Please consider using those abstract types in your canonical type definition.
| opt_uses: | ||
| - failed_supply_fan_alarm | ||
| - failed_exhaust_fan_alarm | ||
| - return_fan_speed_percentage_command |
There was a problem hiding this comment.
How does the return fan work in this instance? Is it a booster back to the exhaust air stream? And why would this not be required if it were part of the coordinated control sequence that this type is trying to describe?
| implements: | ||
| - CONTROL | ||
|
|
||
| FAM: |
There was a problem hiding this comment.
This seems like it could be made optional on the canonical type, or perhaps even on the general type. I dont see the need for a new abstract type for a single point; lets land this somewhere existing.
| is_abstract: true | ||
| uses: | ||
| - heat_recovery_run_command | ||
| - heat_recovery_run_mode |
There was a problem hiding this comment.
Why do we have the mode and the command? Doesnt the mode indicate what the command is doing?
| @@ -90,3 +90,9 @@ SOFTSTART: "Mode of operation of rectifier where the input power supply is gradu | |||
| NORMAL: "Function, state or flow which is an ideal or expected condition." | |||
| REVERSED: "Function, state or flow which is opposed to the expected or normal condition." | |||
|
|
|||
| # FOR HEAT RECOVERY UNIT | |||
| STARTUP: "Operation mode where unit is starting up." | |||
There was a problem hiding this comment.
are startup and warmup modes substantially different from normal operation?
| # FOR HEAT RECOVERY UNIT | ||
| STARTUP: "Operation mode where unit is starting up." | ||
| WARMUP: "Operation mode where unit is warming up." | ||
| OVERRUN: "" |
There was a problem hiding this comment.
This needs specific definition, and should be well-distinguished from all other mode states.
| STARTUP: "Operation mode where unit is starting up." | ||
| WARMUP: "Operation mode where unit is warming up." | ||
| OVERRUN: "" | ||
| INTERMITTENT: "" |
| WARMUP: "Operation mode where unit is warming up." | ||
| OVERRUN: "" | ||
| INTERMITTENT: "" | ||
| FIREMODE: "Operation mode during fire alarm." |
There was a problem hiding this comment.
Would this be a separate operating mode, or would it just be OFF when the fire_alarm field is returning ACTIVE?
| implements: | ||
| - AHU | ||
| - HTSC | ||
| - VOADM |
There was a problem hiding this comment.
This is used when you have a device that mixes return with outside air, usually for economizing purposes. The rest of the context in this PR indicates that what you have is more of a single-pass DOAS system. Can you please confirm the configuration of this device and how it functions? (VOADM defines mixed_air_temperature_sensor, which is only appropriate for systems that can recirculate air from the space, mixing it with outside air).
There was a problem hiding this comment.
Some questions about the configuration and control of this particular device. Please provide comments on how the device controls so we can better advise on how to proceed with the modeling.
If you have any questions or want to provide us with some schematic of the system to help explain it to us, please contact: [email protected]. Happy to set up some time to discuss as well, if that will expedite the process.
|
Thanks for all the feedback so far Trevor. I've updated the |
|
replaced OVERRUN state with FAN_ONLY. Unsure if this is best choice based on information given - "When the HRU is stopped suddenly the supply fan provides an overrun for the heater for 3 minutes." |
|
@adelin-diac is this pr still needed? |
|
Same as #1001, @kevin-hereworks can confirm if still needed. |
@kevin-hereworks