Pandora: Fix l2cap receive rpc #541
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilverBzH
reviewed
Aug 27, 2024
bumble/pandora/l2cap.py
Outdated
Comment on lines
64
to
67
| def on_channel_sdu(self, sdu): | ||
| async def handle_sdu(): | ||
| await self.sdu_queue.put(sdu) | ||
|
|
||
| asyncio.create_task(handle_sdu()) |
There was a problem hiding this comment.
Please use synchronized Queue instead:
https://docs.python.org/3/library/queue.html
Suggested change
| def on_channel_sdu(self, sdu): | |
| async def handle_sdu(): | |
| await self.sdu_queue.put(sdu) | |
| asyncio.create_task(handle_sdu()) | |
| def on_channel_sdu(self, sdu): | |
| self.sdu_queue.put_nowait(sdu) |
atorodotme
force-pushed
the
satoro/bumble_pandora_l2cap_receive
branch
from
88b3ae9
to
3ae19f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.