feat!: Use CSS to specify field cursors. #8648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
breaking change
cpcallen
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
CURSORproperty #8319Proposed Changes
This PR removes the
CURSORfield from fields, and instead uses CSS to specify which cursor should be used for which fields. This directly fixes #8319. #2885 and #2884 are old bugs proposing adding options to inject classes into fields and refactoring theCURSORfield, which I believe are obsolete in light of the move to CSS. All core fields now add a class specifying the type of field, and custom field subclasses can also easily do this. As a result, users should be able to use CSS to customize the appearance of fields in general and their cursors in particular.#995 was incidentally fixed here, since now that we're using CSS to specify cursors, it's trivial to specify the grabby cursor for fields when their parent block is being dragged.