Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure reported Time is walltime by removing spurious scaling by threads #1836

Merged
merged 7 commits into from
Aug 13, 2024
Merged

Ensure reported Time is walltime by removing spurious scaling by threads #1836

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3053d1b
Introduce per-thread times to console and json reporters
dmah42 Aug 7, 2024
a1c840f
clang-format
dmah42 Aug 7, 2024
0d52a11
more clang-format
dmah42 Aug 7, 2024
9a2d246
change the default to not scale
dmah42 Aug 9, 2024
5fde8c0
remove unused statements
dmah42 Aug 9, 2024
f834669
clang-format
dmah42 Aug 9, 2024
4827765
left a bit behind by mistake
dmah42 Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/benchmark_runner.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,12 +292,6 @@ BenchmarkRunner::IterationResults BenchmarkRunner::DoNIterations() {
// And get rid of the manager.
manager.reset();

// Adjust real/manual time stats since they were reported per thread.
i.results.real_time_used /= b.threads();
i.results.manual_time_used /= b.threads();
// If we were measuring whole-process CPU usage, adjust the CPU time too.
if (b.measure_process_cpu_time()) i.results.cpu_time_used /= b.threads();

BM_VLOG(2) << "Ran in " << i.results.cpu_time_used << "/"
<< i.results.real_time_used << "\n";

Expand Down
2 changes: 1 addition & 1 deletion src/console_reporter.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ void ConsoleReporter::PrintRunData(const Run& result) {
big_o.c_str(), cpu_time, big_o.c_str());
} else if (result.report_rms) {
printer(Out, COLOR_YELLOW, "%10.0f %-4s %10.0f %-4s ", real_time * 100, "%",
cpu_time * 100, "%");
dmah42 marked this conversation as resolved.
Show resolved Hide resolved
"%", cpu_time * 100, "%");
} else if (result.run_type != Run::RT_Aggregate ||
result.aggregate_unit == StatisticUnit::kTime) {
const char* timeLabel = GetTimeUnitString(result.time_unit);
Expand Down
Loading