Skip to content

Commit

Permalink
Fix malformed clang invocation in build_ext.run (#1884)
Browse files Browse the repository at this point in the history
The fix is, unsurprisingly, to not invoke clang at all, because we use
Bazel to build everything anyway.

This also means that we can drop the setuptools pin.
  • Loading branch information
nicholasjng authored Dec 3, 2024
1 parent 3d88aff commit b2b0aab
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[build-system]
requires = ["setuptools<73"]
requires = ["setuptools"]
build-backend = "setuptools.build_meta"

[project]
Expand Down
1 change: 0 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ class BuildBazelExtension(build_ext.build_ext):
def run(self):
for ext in self.extensions:
self.bazel_build(ext)
super().run()
# explicitly call `bazel shutdown` for graceful exit
self.spawn(["bazel", "shutdown"])

Expand Down

0 comments on commit b2b0aab

Please sign in to comment.