Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docs for Activity flow #2735

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aditya-07
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #[issue number]

Description
Clear and concise code change description.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@@ -22,6 +22,7 @@ Future features of the library will provide support for Tasking and other Workfl
* [Evaluate a Measure](Evaluate-a-Measure.md)
* [Evaluate a Library](Evaluate-a-Library.md)
* [Compile CQL](Compile-and-Execute-CQL.md)
* [Run an Activity Flow](Run-an-Activity-Flow.md)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would put this after generate care plan, and before evaluate measure.

actually maybe separate this list into 2. one list includes care plan generation, activity flow, and measure - and we can call it workflow guides.... and another list including the other two, maybe call it "other operations" or soemthign similar?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a short paragraph on top of this page in the right order to describe this step in between generation of care plan and the measure evaluation.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have a simple diagram to explain the phases. no need to discuss the intents of the phases (we're trying to hide those things from developers) but just the phases and transitions.

but also - add something about the fact that this api makes it easy for you to implement the activity flow - because we manage the resources, and manage the intents and statuses to make sure they are compliant with the cpg ig.

val planPhase = flow.initiatePlan(preparedPlan).getOrThrow( )
```

## Transitioning to Perform Phase
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

say that perform is a special phase that needs an event

* **`RequestPhase`:** (`ProposalPhase`, `PlanPhase`, `OrderPhase`) allows updating the request state using `update()`.
* **`EventPhase`:** (`PerformPhase`) allows updating the event state using `update()` and completing the phase using `complete()`.

## Factory Functions
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have a section called api list, and list the factory functions and other functions - or, if these are covered and clear enough from previous sections, we don't ahve to have this separate list.

or maybe these can be part of the diagram if you can squeeze them in.

Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also please add a page for the demo app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants