Move the parallelized mapping outside db transaction #2715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndegwamartin
added a commit
to opensrp/android-fhir
that referenced
this pull request
Nov 12, 2024
FORK
- With unmerged PR #9
- WUP #13
SDK
- WUP google#2178
- WUP google#2650
- WUP google#2663
- WUP google#2645
- WUP google#2715
FikriMilano
reviewed
Nov 24, 2024
Comment on lines
+232
to
244
| val dbResult = | ||
| db.withTransaction { | ||
| resourceDao.getResources(SimpleSQLiteQuery(query.query, query.args.toTypedArray())) | ||
| } | ||
|
|
||
| return dbResult.pmap( | ||
| Dispatchers.Default, | ||
| ) { | ||
| ResourceWithUUID( | ||
| it.uuid, | ||
| FhirContext.forR4Cached().newJsonParser().parseResource(it.serializedResource) as R, | ||
| ) | ||
| } |
There was a problem hiding this comment.
The updated code adds more readability, which is nice. But I'm ok w the previous too.
I've no strong opinion about this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #[issue number]
Description
Moved the parallized parsing of resources fetched from DB to be done outside the db trnsaction lambda
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.