Add exclude param #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump |
|
Sorry for being so late, must have missed the notification. The request looks good. I'll take care of it soon. Have you already signed the CLA as per the Contributing paragraph in the README (https://github.com/google/adb-sync/blob/master/README.md)? |
|
This was the only thing missing for me too. For when I backup my internal storage I don't want to copy TWRP and some huge folders. Thank you for making this. |
baohaojun
reviewed
Dec 28, 2016
| for f in file_iter: | ||
| excluded = False | ||
| for pat in excludes: | ||
| if fnmatch.fnmatch(f[0], pat): |
There was a problem hiding this comment.
thats correct, since its a tuple:
('/file/abc', posix.stat_result(st_mode=16877, st_ino=1, st_dev=0, st_nlink=1, st_uid=-2, st_gid=-2, st_size=None, st_atime=1528642980.0, st_mtime=1528642980.0, st_ctime=1528642980.0))
f[0] is the '/file/abc'
Razerban
added a commit
to Razerban/adb-sync
that referenced
this pull request
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed this because I am "force synching" folders already synched by btsync, which has a ".sync" hidden folder which should not be checked.
If it is not a proper PR for this project, please let me now.