Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug in Orbax checkpointing where None values PyTree are not handled correctly. This is caused by a recent update in jax where None values are no longer considered as a leaf node: https://jax.readthedocs.io/en/latest/changelog.html#jax-0-4-34-october-4-2024. #1604

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

Fix a bug in Orbax checkpointing where None values PyTree are not handled correctly. This is caused by a recent update in jax where None values are no longer considered as a leaf node: https://jax.readthedocs.io/en/latest/changelog.html#jax-0-4-34-october-4-2024. #1604

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion t5x/checkpoints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2165,7 +2165,12 @@ def _modify_orbax_param_info(info, value):
)
return info

item_ = jax.tree.map(_make_orbax_internal_metadata, item_, restore_args)
item_ = jax.tree.map(
lambda x, y: None if x is None else _make_orbax_internal_metadata(x, y),
item_,
restore_args,
is_leaf=lambda x: x is None,
)
param_infos_, _ = checkpoint_utils.get_restore_parameters(directory_, item_)
param_infos_ = jax.tree.map(
_modify_orbax_param_info, param_infos_, state_dict_to_restore
Expand Down
Loading