[WIP] Add TGLFInputs and TGLFNN #477
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
This will make it easier to integrate non-Qualikiz-based quasilinear transport models. PiperOrigin-RevId: 691455432
theo-brown
force-pushed
the
tglf-surrogate
branch
from
5c2a110
to
6a95a95
Compare
|
@lorenzozanisi could you lend a hand with checking the normalisations? |
theo-brown
commented
Nov 21, 2024
| / (CONSTANTS.qe * geo.B0) ** 2 | ||
| * (Ti.face_value() * CONSTANTS.keV2J) ** 1.5 | ||
| / lref | ||
| ) |
There was a problem hiding this comment.
Is this definition (chiGB) correct / consistent with TGLF?
theo-brown
commented
Nov 21, 2024
| ) | ||
| # Shear uses rho_face_norm | ||
| # TODO: check whether this should be midplane R | ||
| s_hat = physics.calc_s_from_psi(geo, core_profiles.psi) # = r/q dq/dr |
There was a problem hiding this comment.
Should this be w.r.t midplane R, or rho?
Compute gradients at rmid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
TGLFInputsclass andTGLFNNmodel.Note: completion depends on other work in progress in #476.
Remaining tasks:
QuasilinearTransportModelInputsQuasilinearTransportModelphysics.py