Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated multiple typo's #5775

Merged
merged 2 commits into from
Jan 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ void ConfigureLandmarksSmoothingCalculator(
// Min cutoff 0.05 results into ~0.01 alpha in landmark EMA filter when
// landmark is static.
options.mutable_one_euro_filter()->set_min_cutoff(0.05f);
// Beta 80.0 in combintation with min_cutoff 0.05 results into ~0.94
// Beta 80.0 in combination with min_cutoff 0.05 results into ~0.94
// alpha in landmark EMA filter when landmark is moving fast.
options.mutable_one_euro_filter()->set_beta(80.0f);
// Derivative cutoff 1.0 results into ~0.17 alpha in landmark velocity
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ absl::Status TensorsToImageCalculator::UpdateContract(CalculatorContract* cc) {
MP_RETURN_IF_ERROR([MPPMetalHelper updateContract:cc]);
#else
return GlCalculatorHelper::UpdateContract(cc,
/*requesst_gpu_as_optional=*/true);
/*request_gpu_as_optional=*/true);
#endif // MEDIAPIPE_METAL_ENABLED
#endif // !MEDIAPIPE_DISABLE_GPU
return absl::OkStatus();
Expand Down
2 changes: 1 addition & 1 deletion third_party/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ cmake(
# For example, when building //mediapipe/calculators/video:opencv_video_encoder_calculator_test,
# the dependency //mediapipe/framework/formats:image_frame_opencv will
# be built as a shared library, which depends on a cv::Mat constructor,
# and expects it to be provided by the main exacutable. The main
# and expects it to be provided by the main executable. The main
# executable depends on libimage_frame_opencv.so and links in
# libopencv_core.a, which contains cv::Mat. However, if
# libopencv_core.a marks its symbols as hidden, then cv::Mat is in
Expand Down
2 changes: 1 addition & 1 deletion third_party/com_google_sentencepiece.diff
Original file line number Diff line number Diff line change
Expand Up @@ -1204,7 +1204,7 @@ index e8bd5f5..346fb0e 100644
std::string *detokenized) const;

// Sets the encoder version. Normally users do not need to call this function.
// But they can call this fucntion just in case if they want to fall back to
// But they can call this function just in case if they want to fall back to
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't fix this since this is part of the sentencepiece repo (as a diffbase).

// the original encoder.
- virtual util::Status SetEncoderVersion(EncoderVersion encoder_version);
+ virtual absl::Status SetEncoderVersion(EncoderVersion encoder_version);
Expand Down
2 changes: 1 addition & 1 deletion third_party/opencv_ios_source.BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ cc_library(
"@//mediapipe:ios_arm64": [
":opencv_xcframework_device_headers",
],
# A value from above is chosen arbitarily.
# A value from above is chosen arbitrarily.
"//conditions:default": [
":opencv_xcframework_simulator_headers",
],
Expand Down
2 changes: 1 addition & 1 deletion third_party/opencv_ios_source.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ _OPENCV_SIMULATOR_PLATFORM_DIR_NAME = "ios-arm64_x86_64-simulator"
_OPENCV_DEVICE_PLATFORM_DIR_NAME = "ios-arm64"

def _select_headers_impl(ctx):
# Should match with `/`. Othewise `ios-arm64` matches with `ios-arm64_x86-64`
# Should match with `/`. Otherwise `ios-arm64` matches with `ios-arm64_x86-64`
_files = [
f
for f in ctx.files.srcs
Expand Down
4 changes: 2 additions & 2 deletions third_party/org_tensorflow_custom_ops.diff
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ index 00000000000..4e73cf649e6
+ if (node_inputs.size() != 1) {
+ return {TransformStatus::SKIPPED, ""};
+ }
+ // Recognize preeceding scalar Mul operation and save the value.
+ // Recognize preceding scalar Mul operation and save the value.
+ auto mul = graph->FindProducer(node_inputs[0]->id);
+ if (mul->operation.type != ToString(OperationType::MUL)) {
+ return {TransformStatus::SKIPPED, ""};
Expand Down Expand Up @@ -620,7 +620,7 @@ index 00000000000..fba7e742998
+ "Landmarks operation's output value."};
+ }
+
+ // Delete preceding and succeding Reshape operations.
+ // Delete preceding and succeeding Reshape operations.
+ absl::Status removed_preceding =
+ RemoveSimpleNodeKeepInput(graph, preceding_reshape);
+ if (!removed_preceding.ok()) {
Expand Down