Fix DrawingUtils constructor failing in Web Workers #5489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this commit, the DrawingUtils constructor fails in Web Workers because the CanvasRenderingContext2D is not available in the worker context. This commit adds a check whether the CanvasRenderingContext2D is defined before using it. Fixes google-ai-edge#5284
|
Hi @mbrenon, Could you please review this fix for the DrawingUtils constructor failing in Web Workers? Thank you!! |
|
This is still an issue with 0.10.18 (and it looks like there's another breakage in 0.10.20). Can you please merge ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this commit, the DrawingUtils constructor fails in Web Workers because the CanvasRenderingContext2D is not available in the worker context.
This commit adds a check whether the CanvasRenderingContext2D is defined before using it.
Fixes #5284