Disallow quotes outside strings and multiline strings #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quotes are now only allowed to delimit strings or as escaped characters within strings. This commit also changes the PEG grammar to disallow line-breaking spaces within strings so it more accurately represents the line-based parsing behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion in #143, quotation marks should not be parsed as symbols when they appear alone. Making this change also implies that quotation marks are not allowed as role names (
:"). This PR also changes the documented PEG grammar to explicitly say that line-breaking spaces (\n\r\v\f) are not allowed inside strings, which makes it consistent with how parsing is actually done.