feat: FilterView management in pythonSDK #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbonilla95
requested review from
lupko,
pcerny,
jaceksan and
hkad98
as code owners
hkad98
reviewed
Nov 12, 2024
chrisbonilla95
force-pushed
the
cbon-lx-428-saved-filter-views-mgmt-in-pythonsdk
branch
3 times, most recently
from
27300fa to
12bef5e
Compare
hkad98
reviewed
Nov 13, 2024
chrisbonilla95
force-pushed
the
cbon-lx-428-saved-filter-views-mgmt-in-pythonsdk
branch
from
12bef5e to
5fe55a7
Compare
|
I do not see any tests. Could you please add some? |
hkad98
requested changes
Nov 13, 2024
gooddata-sdk/gooddata_sdk/catalog/workspace/declarative_model/workspace/workspace.py
Outdated
Show resolved
Hide resolved
gooddata-sdk/gooddata_sdk/catalog/workspace/declarative_model/workspace/workspace.py
Outdated
Show resolved
Hide resolved
gooddata-sdk/gooddata_sdk/catalog/workspace/entity_model/filter_view.py
Outdated
Show resolved
Hide resolved
gooddata-sdk/gooddata_sdk/catalog/workspace/entity_model/filter_view.py
Outdated
Show resolved
Hide resolved
gooddata-sdk/gooddata_sdk/catalog/workspace/entity_model/filter_view.py
Outdated
Show resolved
Hide resolved
chrisbonilla95
force-pushed
the
cbon-lx-428-saved-filter-views-mgmt-in-pythonsdk
branch
2 times, most recently
from
7219208 to
2964993
Compare
Enabling management of FilterViews via pythonSDK JIRA: LX-428 risk: low
chrisbonilla95
force-pushed
the
cbon-lx-428-saved-filter-views-mgmt-in-pythonsdk
branch
from
2964993 to
a70d67b
Compare
hkad98
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the management of FilterViews from the pythonSDK
JIRA: LX-428
risk: low