Merge pull request #406 from hkad98/trivial

TRIVIAL: fix wrong definition for workspace permissions

Reviewed-by: Jan Kadlec
             https://github.com/hkad98

gooddata-sdk/gooddata_sdk/__init__.py

@@ -82,7 +82,7 @@
 )
 from gooddata_sdk.catalog.permission.declarative_model.manage_dashboard_permissions import (
     CatalogDashboardAssigneeIdentifier,
-    CatalogPermissionsForAssignee,
+    CatalogPermissionsForAssigneeIdentifier,
     CatalogPermissionsForAssigneeRule,
 )
 from gooddata_sdk.catalog.permission.declarative_model.permission import (

gooddata-sdk/gooddata_sdk/catalog/permission/declarative_model/manage_dashboard_permissions.py

@@ -16,7 +16,7 @@ class CatalogDashboardAssigneeIdentifier(CatalogAssigneeIdentifier):
 
 
 @attr.s(auto_attribs=True, kw_only=True)
-class CatalogPermissionsForAssignee(Base):
+class CatalogPermissionsForAssigneeIdentifier(Base):
     permissions: List[str] = attr.field(factory=list)
     assignee_identifier: CatalogAssigneeIdentifier
 

gooddata-sdk/gooddata_sdk/catalog/permission/declarative_model/permission.py

@@ -65,7 +65,7 @@ def client_class() -> Type[DeclarativeWorkspacePermissions]:
 @attr.s(auto_attribs=True, kw_only=True)
 class CatalogDeclarativeDashboardPermissionsForAssignee(Base):
     name: str = attr.field(validator=value_in_allowed)
-    assignee_identifier: CatalogAssigneeIdentifier
+    assignee: CatalogAssigneeIdentifier
 
     @staticmethod
     def client_class() -> Type[DeclarativeAnalyticalDashboardPermissionForAssignee]:

gooddata-sdk/gooddata_sdk/catalog/permission/service.py

@@ -7,7 +7,7 @@
     CatalogDeclarativeOrganizationPermission,
     CatalogDeclarativeWorkspacePermissions,
     CatalogOrganizationPermissionAssignment,
-    CatalogPermissionsForAssignee,
+    CatalogPermissionsForAssigneeIdentifier,
     CatalogPermissionsForAssigneeRule,
     GoodDataApiClient,
 )
@@ -87,7 +87,9 @@ def manage_dashboard_permissions(
         self,
         workspace_id: str,
         dashboard_id: str,
-        permissions_for_assignee: List[Union[CatalogPermissionsForAssignee, CatalogPermissionsForAssigneeRule]],
+        permissions_for_assignee: List[
+            Union[CatalogPermissionsForAssigneeIdentifier, CatalogPermissionsForAssigneeRule]
+        ],
     ) -> None:
         """Provide managing dashboard permissions for user and user groups.
 
@@ -96,9 +98,9 @@ def manage_dashboard_permissions(
                 Workspace identification string. e.g. "demo"
             dashboard_id (str):
                 Dashboard identification string. e.g. "campaign"
-            permissions_for_assignee ([CatalogPermissionsForAssignee]):
-                Object containing List of users and user group and desired dashboard permissions. Set empty list
-                permissions for user/user group means remove dashboard permissions.
+            permissions_for_assignee ([Union[CatalogPermissionsForAssignee, CatalogPermissionsForAssigneeRule]]):
+                Object containing a List of permission assignments. An empty list of permissions in the assignment
+                removes existing dashboard permissions.
         Returns:
             None
         """

gooddata-sdk/gooddata_sdk/catalog/workspace/declarative_model/workspace/analytics_model/analytics_model.py

@@ -240,7 +240,7 @@ def structure_permissions(
     ) -> Union[
         CatalogDeclarativeDashboardPermissionsForAssignee, CatalogDeclarativeDashboardPermissionsForAssigneeRule
     ]:
-        if v.get("assignee_identifier") is not None:
+        if v.get("assignee") is not None:
             return structure(v, CatalogDeclarativeDashboardPermissionsForAssignee)
         else:
             return structure(v, CatalogDeclarativeDashboardPermissionsForAssigneeRule)