🐛 Fix override for C platforms #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakarias88
approved these changes
Sep 12, 2024
abbec
force-pushed
the
fix-c-override
branch
2 times, most recently
from
dec1bcf to
33dc3d6
Compare
After calling `overrideFactory` on a C platform, the `override` function was dropped from the resulting set.
abbec
force-pushed
the
fix-c-override
branch
from
33dc3d6 to
8ac9ff9
Compare
Previously, setting `output` would make the derivation end up on the correct component attribute but when splicing happened it would look for the target named by `name` in other components.
abbec
force-pushed
the
fix-c-override
branch
from
8ac9ff9 to
9733726
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After calling
overrideFactoryon a C platform, theoverridefunction was dropped from the resulting set.