This repository has been archived by the owner on Sep 6, 2022. It is now read-only.
⚡ Add support for copying of DayuTimeCode objects #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI became super sad when I moved the repo for some reason. Hoping it will
fix itself when I change commit msg
…On Sun, Jun 14, 2020, 21:12 Simon Rainerson ***@***.***> wrote:
***@***.**** commented on this pull request.
Commit message and PR title should say Add instead of Added. And your CI
is having troubles, But code looks good to me.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARNTMM3CTC27LIHQVJUSVLRWUOJ3ANCNFSM4N5QY44Q>
.
|
Eiken
changed the title
Changed to Add |
simonrainerson
approved these changes
Jun 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved dayu_timecode to gbk and created a pull request for our repo if dayu maintainers dont merge the PR