Add log formatting settings #1926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrPsychick
referenced
this pull request
in gomods/athens-charts
Apr 16, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [gomods/athens](https://togithub.com/gomods/athens) | patch | `v0.13.1` -> `v0.13.3` | --- ### Release Notes <details> <summary>gomods/athens (gomods/athens)</summary> ### [`v0.13.3`](https://togithub.com/gomods/athens/releases/tag/v0.13.3) [Compare Source](https://togithub.com/gomods/athens/compare/v0.13.2...v0.13.3) #### What's Changed - Update README.md by [@​computerscienceiscool](https://togithub.com/computerscienceiscool) in [https://github.com/gomods/athens/pull/1932](https://togithub.com/gomods/athens/pull/1932) - update-go-pkg(deps): bump github.com/stretchr/testify from 1.8.4 to 1.9.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/gomods/athens/pull/1933](https://togithub.com/gomods/athens/pull/1933) - Upgrade logrus from 1.7.0 => 1.9.3 by [@​matt0x6F](https://togithub.com/matt0x6F) in [https://github.com/gomods/athens/pull/1934](https://togithub.com/gomods/athens/pull/1934) - should use errors.AsErr to extract and detect errors.Error by [@​kkHAIKE](https://togithub.com/kkHAIKE) in [https://github.com/gomods/athens/pull/1936](https://togithub.com/gomods/athens/pull/1936) - correcting the misuse of the context in the copyContextWithCustomTime… by [@​kkHAIKE](https://togithub.com/kkHAIKE) in [https://github.com/gomods/athens/pull/1941](https://togithub.com/gomods/athens/pull/1941) - remove hardcoded rootPath values by [@​Jeansen](https://togithub.com/Jeansen) in [https://github.com/gomods/athens/pull/1874](https://togithub.com/gomods/athens/pull/1874) #### New Contributors - [@​computerscienceiscool](https://togithub.com/computerscienceiscool) made their first contribution in [https://github.com/gomods/athens/pull/1932](https://togithub.com/gomods/athens/pull/1932) - [@​kkHAIKE](https://togithub.com/kkHAIKE) made their first contribution in [https://github.com/gomods/athens/pull/1936](https://togithub.com/gomods/athens/pull/1936) - [@​Jeansen](https://togithub.com/Jeansen) made their first contribution in [https://github.com/gomods/athens/pull/1874](https://togithub.com/gomods/athens/pull/1874) **Full Changelog**: gomods/athens@v0.13.2...v0.13.3 ### [`v0.13.2`](https://togithub.com/gomods/athens/releases/tag/v0.13.2) [Compare Source](https://togithub.com/gomods/athens/compare/v0.13.1...v0.13.2) #### What's Changed - Send standard logger's output to logrus by [@​mikesep](https://togithub.com/mikesep) in [https://github.com/gomods/athens/pull/1912](https://togithub.com/gomods/athens/pull/1912) - chore: fix broken links to 'absolutely everybody' blog post by [@​darrylblake](https://togithub.com/darrylblake) in [https://github.com/gomods/athens/pull/1914](https://togithub.com/gomods/athens/pull/1914) - update-github-action(deps): bump golangci/golangci-lint-action from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/gomods/athens/pull/1915](https://togithub.com/gomods/athens/pull/1915) - update-go-pkg(deps): bump github.com/gorilla/mux from 1.6.2 to 1.8.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/gomods/athens/pull/1917](https://togithub.com/gomods/athens/pull/1917) - update-go-pkg(deps): bump github.com/stretchr/testify from 1.8.1 to 1.8.4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/gomods/athens/pull/1918](https://togithub.com/gomods/athens/pull/1918) - update-go-pkg(deps): bump go.etcd.io/etcd/api/v3 from 3.5.9 to 3.5.12 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/gomods/athens/pull/1919](https://togithub.com/gomods/athens/pull/1919) - Fix Markdown link in Storage docs by [@​chriskuehl](https://togithub.com/chriskuehl) in [https://github.com/gomods/athens/pull/1922](https://togithub.com/gomods/athens/pull/1922) - Use quotes for args by [@​matt0x6F](https://togithub.com/matt0x6F) in [https://github.com/gomods/athens/pull/1925](https://togithub.com/gomods/athens/pull/1925) - Add log formatting settings by [@​matt0x6F](https://togithub.com/matt0x6F) in [https://github.com/gomods/athens/pull/1926](https://togithub.com/gomods/athens/pull/1926) - upgrade mongodb driver by [@​xytan0056](https://togithub.com/xytan0056) in [https://github.com/gomods/athens/pull/1928](https://togithub.com/gomods/athens/pull/1928) - update-go-pkg(deps): bump github.com/lib/pq from 1.10.7 to 1.10.9 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/gomods/athens/pull/1923](https://togithub.com/gomods/athens/pull/1923) - Rework logging defaults by [@​matt0x6F](https://togithub.com/matt0x6F) in [https://github.com/gomods/athens/pull/1927](https://togithub.com/gomods/athens/pull/1927) #### New Contributors - [@​darrylblake](https://togithub.com/darrylblake) made their first contribution in [https://github.com/gomods/athens/pull/1914](https://togithub.com/gomods/athens/pull/1914) - [@​chriskuehl](https://togithub.com/chriskuehl) made their first contribution in [https://github.com/gomods/athens/pull/1922](https://togithub.com/gomods/athens/pull/1922) - [@​matt0x6F](https://togithub.com/matt0x6F) made their first contribution in [https://github.com/gomods/athens/pull/1925](https://togithub.com/gomods/athens/pull/1925) **Full Changelog**: gomods/athens@v0.13.1...v0.13.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/gomods/athens-charts). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMDEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjMwMS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem I am trying to address?
Log formatting can only be configured via the
CloudRuntimesetting which does some niche formatting based on Google Cloud Platform logging norms. Athens settings, however, should favor configuration that is not reliant on cloud provider behavior.ATHENS_LOG_FORMATintroduces the ability to configureplainorjsonloggers whenCloudRuntimeisnone(default).How is the fix applied?
Introducing a setting for
LogFormatwhich can beplainorjson. Defaults tojson(original behavior).What GitHub issue(s) does this PR fix or close?
Fixes #1924