Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

singleflight go commands #1877

Merged
merged 2 commits into from
Dec 21, 2023
Merged

singleflight go commands #1877

merged 2 commits into from
Dec 21, 2023

Conversation

wozz
Copy link
Contributor

@wozz wozz commented Jul 21, 2023

What is the problem I am trying to address?

see: #1876

How is the fix applied?

Use singleflight package to ensure identical go commands are not run simultaneously.

What GitHub issue(s) does this PR fix or close?

@wozz wozz requested a review from a team as a code owner July 21, 2023 13:32
@wozz wozz mentioned this pull request Jul 21, 2023
Closed
Ullaakut
Ullaakut approved these changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@Ullaakut Ullaakut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick, besides that LGTM and seems to address the problem mentioned in the issue just fine.

pkg/module/go_get_fetcher.go Outdated Show resolved Hide resolved
pkg/module/go_vcs_lister.go Outdated Show resolved Hide resolved
@nrwiersma nrwiersma merged commit 3af0d00 into gomods:main Dec 21, 2023
11 checks passed
@DrPsychick DrPsychick added this to the 0.13.1 milestone Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ullaakut Ullaakut Ullaakut approved these changes

@nrwiersma nrwiersma nrwiersma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13.1
Development

Successfully merging this pull request may close these issues.
5 participants
@wozz @nrwiersma @Ullaakut @DrPsychick @mwoz-sc