replaces travis ci by github actions and adds quality tools (#44)

* replaces travis ci by github actions * adds codecov.yml file
golossus · Sep 14, 2021 · 456ee1f · 456ee1f
1 parent 3e4f196
commit 456ee1f
Show file tree

Hide file tree

Showing 8 changed files with 71 additions and 28 deletions.
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
@@ -0,0 +1,7 @@
+version: 2
+updates:
+  - package-ecosystem: gomod
+    directory: "/"
+    schedule:
+      interval: weekly
+    open-pull-requests-limit: 10
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -0,0 +1,51 @@
+name: ci
+
+on: [push, pull_request]
+
+jobs:
+
+  build:
+    name: ci-build
+    strategy:
+      fail-fast: false
+      matrix:
+        os:
+          - ubuntu-latest
+        go:
+          - '1.17'
+          - '1.16'
+          - '1.15'
+          - '1.14'
+          - '1.13'
+          - '1.12'
+          - '1.11'
+          - '1.10'
+    runs-on: ${{ matrix.os }}
+    steps:
+
+      - name: Set up Go runtime
+        uses: actions/setup-go@v2
+        with:
+          go-version: ${{ matrix.go }}
+
+      - name: Check out repository code
+        uses: actions/checkout@v2
+
+      - name: Get dependencies
+        run: go get -v -t -d ./...
+
+      - name: Run golangci-lint
+        uses: golangci/golangci-lint-action@v2
+
+      - name: Test
+        run: go test -race -coverprofile=coverage.txt -covermode=atomic ./...
+
+      - name: Send coverage metrics to Codecov
+        if: ${{ matrix.go == '1.17' }}
+        uses: codecov/codecov-action@v2
+        with:
+          token: ${{ secrets.CODECOV_TOKEN }}
+          file: ./coverage.txt
+          flags: unittests
+          fail_ci_if_error: false
+
diff --git a/.travis.yml b/.travis.yml
diff --git a/README.md b/README.md
@@ -1,6 +1,9 @@
-[![Go Report Card](https://goreportcard.com/badge/github.com/golossus/routing)](https://goreportcard.com/report/github.com/golossus/routing) 
-[![Build Status](https://travis-ci.com/golossus/routing.svg?branch=master)](https://travis-ci.com/golossus/routing)
+![ci workflow](https://github.com/golossus/routing/actions/workflows/ci.yml/badge.svg)
 [![codecov](https://codecov.io/gh/golossus/routing/branch/master/graph/badge.svg?token=R4RDS0JM4X)](https://codecov.io/gh/golossus/routing)
+[![Go Report Card](https://goreportcard.com/badge/github.com/golossus/routing)](https://goreportcard.com/report/github.com/golossus/routing)
+[![CodeFactor](https://www.codefactor.io/repository/github/golossus/routing/badge)](https://www.codefactor.io/repository/github/golossus/routing)
+[![Quality Gate Status](https://sonarcloud.io/api/project_badges/measure?project=golossus_routing&metric=alert_status)](https://sonarcloud.io/dashboard?id=golossus_routing)
+
 
 <p align="center">
     <a href="https://www.golossus.com" target="_blank">

diff --git a/bench_router_test.go b/bench_router_test.go
@@ -191,7 +191,7 @@ func BenchmarkRouter_GenerateURL(b *testing.B) {
 	paramsKey.add("id", "2")
 	paramsKey.add("name", "john")
 	for i := 0; i < b.N; i++ {
-		mainRouter.GenerateURL("path1.id.name", paramsKey)
+		_, _ = mainRouter.GenerateURL("path1.id.name", paramsKey)
 	}
 }
 
@@ -202,7 +202,7 @@ func benchRouter(b *testing.B, prioritizeByWeight bool) {
 	before := m.HeapAlloc
 	handler := func(response http.ResponseWriter, request *http.Request) {}
 	for _, routes := range testRoutes {
-		router.Register(http.MethodGet, routes, handler)
+		_ = router.Register(http.MethodGet, routes, handler)
 	}
 	if prioritizeByWeight {
 		router.PrioritizeByWeight()

diff --git a/codecov.yml b/codecov.yml
@@ -0,0 +1,2 @@
+codecov:
+  require_ci_to_pass: no
diff --git a/fixtures/test.html b/fixtures/test.html
@@ -1,4 +1,5 @@
-<html>
+<!DOCTYPE html>
+<html lang="en">
 <head>
     <title>Test</title>
 </head>

diff --git a/router.go b/router.go
@@ -265,11 +265,11 @@ func (r *Router) Register(verb, path string, handler http.HandlerFunc, options .
 	r.routes[rname] = leaf
 
 	if r.config.EnableAutoMethodHead && verb == http.MethodGet {
-		err = r.Register(http.MethodHead, path, handler, options...)
+		_ = r.Register(http.MethodHead, path, handler, options...)
 	}
 
 	if r.config.EnableAutoMethodOptions && verb != http.MethodOptions {
-		err = r.Register(http.MethodOptions, path, getAutoMethodOptionsHandler(r), options...)
+		_ = r.Register(http.MethodOptions, path, getAutoMethodOptionsHandler(r), options...)
 	}
 
 	return nil