Record errors, fix wrong invalid_amount error msg

golos-blockchain · Nov 12, 2023 · bb62cf3 · bb62cf3
1 parent 65c0447
commit bb62cf3
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 8 deletions.
diff --git a/app/components/cards/PostFull.jsx b/app/components/cards/PostFull.jsx
@@ -11,7 +11,6 @@ import { repLog10, parsePayoutAmount } from 'app/utils/ParsersAndFormatters';
 import extractContent from 'app/utils/ExtractContent';
 import { immutableAccessor, objAccessor } from 'app/utils/Accessors';
 import { isPostVisited, visitPost } from 'app/utils/helpers';
-import { serverApiRecordEvent } from 'app/utils/ServerApiClient';
 import Icon from 'app/components/elements/Icon';
 import TimeVersions from 'app/components/elements/TimeVersions';
 import Voting from 'app/components/elements/Voting';

diff --git a/app/redux/TransactionSaga.js b/app/redux/TransactionSaga.js
@@ -219,12 +219,13 @@ function* broadcastOperation(
             }
         }
         yield call(broadcastPayload, {payload})
-        let eventType = type.replace(/^([a-z])/, g => g.toUpperCase()).replace(/_([a-z])/g, g => g[1].toUpperCase());
-        if (eventType === 'Comment' && !op.parent_author) eventType = 'Post';
-        const page = eventType === 'Vote' ? `@${op.author}/${op.permlink}` : '';
-        serverApiRecordEvent(eventType, page);
     } catch(error) {
         console.error('TransactionSaga', error)
+        try {
+            serverApiRecordEvent('node_error/tx', JSON.stringify(operations) + '        |||        ' + error.toString())
+        } catch (err2) {
+            console.error('Cannot record tx error event:', err2)
+        }
         if(errorCallback) errorCallback(error.toString())
     }
 }
@@ -297,6 +298,12 @@ function* broadcastPayload({payload: {operations, keys, username, hideErrors, su
         console.error('TransactionSaga\tbroadcast', error)
         // status: error
 
+        try {
+            serverApiRecordEvent('node_error/tx_broadcast', JSON.stringify(operations) + '        |||        ' + error.toString())
+        } catch (err2) {
+            console.error('Cannot record tx broadcast error event:', err2)
+        }
+
         yield put(tr.actions.error({operations, error, hideErrors, errorCallback}))
 
         for (const [type, operation] of operations) {

diff --git a/app/redux/Transaction_Error.js b/app/redux/Transaction_Error.js
@@ -142,8 +142,6 @@ export default function transactionErrorReducer(
                 errorKey = errorStr = tt('chain_errors.only_vote_once_every');
             } else if (errorKey.includes('Missing Active Authority')) {
                 errorKey = errorStr = tt('chain_errors.missing_active_authority');
-            } else if (errorKey.includes('')) {
-                errorKey = errorStr = tt('g.invalid_amount');
             } else if (
                 errorKey.includes(
                     'Voting weight is too small, please accumulate more voting power or Golos Power'

diff --git a/server/api/general.js b/server/api/general.js
@@ -75,7 +75,6 @@ export default function useGeneralApi(app) {
             const params = this.request.body;
             const {csrf, type, value} = typeof(params) === 'string' ? JSON.parse(params) : params;
             if (!checkCSRF(this, csrf)) return;
-            console.log('-- /record_event -->', this.session.uid, type, value);
             const str_value = typeof value === 'string' ? value : JSON.stringify(value);
             recordWebEvent(this, type, str_value);
             this.body = JSON.stringify({status: 'ok'});

diff --git a/server/record_web_event.js b/server/record_web_event.js
@@ -1,2 +1,3 @@
 export default function recordWebEvent(ctx, event_type, value) {
+    console.log('-- /record_event -->', event_type, value)
 }