Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default time format #11

Merged

Conversation

t-margheim
Copy link
Contributor

@t-margheim t-margheim commented Sep 20, 2023

This PR closes #10. I updated the default time format to match the expected hours:minutes:seconds. I updated all tests and docs that referenced the previous timestamp (or similar) as well.

@t-margheim t-margheim marked this pull request as ready for review September 20, 2023 21:19
Copy link
Collaborator

@david-littlefarmer david-littlefarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for finding this issue and for PR!!!
Sorry for long silence from me.

@david-littlefarmer david-littlefarmer merged commit 91fbf8c into golang-cz:master Sep 26, 2023
1 check passed
@t-margheim
Copy link
Contributor Author

No worries at all! Thank you for this fantastic library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Default time format includes year instead of minute
2 participants