add FSEvents-based watcher on macOS #10098
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. I will add some comment, but please don't spend time on adjusting your PR until we decide what to do. I have not tested this myself, but I'm assuming that FSEvents is significantly better, and I'm always a fan of that. Somme comments:
I will look closer at this later. |
ok. I will do so. |
|
@arp242 You may want to be aware of this work going on in Hugo. |
satotake
force-pushed
the
fsevents-watcher
branch
from
8519421 to
6e723a8
Compare
On macOS, `fsnotify` uses `kqueue` internally. This causes some long-lasting issues (gohugoio#8594, gohugoio#6109) though we have the workaround for them. This PR tries to resolve these issues by using `FSEvents` instead of `kqueue`. ref https://discourse.gohugo.io/t/fsevents-for-watching-on-macos/39053/4 Use FSEventsWatcher as default on darwin * eventwatcher_darwin.go * NewEventWather returns fsEventWatehr * eventwatcher_other.go * NewEventWather returns fsNotifyWatcher
satotake
force-pushed
the
fsevents-watcher
branch
from
2e2980f to
7dcfd3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS,
fsnotifyuseskqueueinternally.This causes some long-lasting issues (#8594, #6109) though we have the workaround for them.
This PR tries to resolve these issues by using
FSEventsinstead ofkqueue.After applying it, we can use
--enableFSEventsflag like soThere are some considerations.
fsnotify/fseventsmight not be stable yetRelated tests look passed but we have to wait for a while just before adding targets to watch.Otherwise, delayed past events are sent.ref: https://discourse.gohugo.io/t/fsevents-for-watching-on-macos/39053/4