Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix robot deletion event #21234

Merged
merged 4 commits into from
Nov 26, 2024
Merged

fix robot deletion event #21234

merged 4 commits into from
Nov 26, 2024

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Nov 22, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.27%. Comparing base (c8c11b4) to head (778a1e9).
Report is 336 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21234      +/-   ##
==========================================
+ Coverage   45.36%   46.27%   +0.90%     
==========================================
  Files         244      247       +3     
  Lines       13333    13863     +530     
  Branches     2719     2867     +148     
==========================================
+ Hits         6049     6415     +366     
- Misses       6983     7111     +128     
- Partials      301      337      +36     
Flag Coverage Δ
unittests 46.27% <ø> (+0.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 491 files with indirect coverage changes

@OrlinVasilev
Copy link
Member

@wy65701436 is that WIP?

Signed-off-by: wang yan <[email protected]>
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit 29bd094 into goharbor:main Nov 26, 2024
12 checks passed
wy65701436 added a commit to wy65701436/harbor that referenced this pull request Dec 3, 2024
* fix robot deletion event

Signed-off-by: wang yan <[email protected]>

* resolve comments

Signed-off-by: wang yan <[email protected]>

---------

Signed-off-by: wang yan <[email protected]>
wy65701436 added a commit that referenced this pull request Dec 3, 2024
fix robot deletion event (#21234)

* fix robot deletion event



* resolve comments



---------

Signed-off-by: wang yan <[email protected]>
wy65701436 added a commit to wy65701436/harbor that referenced this pull request Dec 4, 2024
* fix robot deletion event

Signed-off-by: wang yan <[email protected]>

* resolve comments

Signed-off-by: wang yan <[email protected]>

---------

Signed-off-by: wang yan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants