-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix robot deletion event #21234
Merged
Merged
fix robot deletion event #21234
+35
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21234 +/- ##
==========================================
+ Coverage 45.36% 46.27% +0.90%
==========================================
Files 244 247 +3
Lines 13333 13863 +530
Branches 2719 2867 +148
==========================================
+ Hits 6049 6415 +366
- Misses 6983 7111 +128
- Partials 301 337 +36
Flags with carried forward coverage won't be shown. Click here to find out more. |
@wy65701436 is that WIP? |
wy65701436
force-pushed
the
rm-robot-event
branch
from
November 24, 2024 18:23
09a7ea5
to
1269ecd
Compare
Signed-off-by: wang yan <[email protected]>
wy65701436
force-pushed
the
rm-robot-event
branch
from
November 24, 2024 20:10
1269ecd
to
6c6d961
Compare
chlins
reviewed
Nov 25, 2024
Signed-off-by: wang yan <[email protected]>
wy65701436
force-pushed
the
rm-robot-event
branch
from
November 25, 2024 03:26
947c105
to
99c44ba
Compare
chlins
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
stonezdj
approved these changes
Nov 26, 2024
wy65701436
added a commit
to wy65701436/harbor
that referenced
this pull request
Dec 3, 2024
* fix robot deletion event Signed-off-by: wang yan <[email protected]> * resolve comments Signed-off-by: wang yan <[email protected]> --------- Signed-off-by: wang yan <[email protected]>
wy65701436
added a commit
that referenced
this pull request
Dec 3, 2024
fix robot deletion event (#21234) * fix robot deletion event * resolve comments --------- Signed-off-by: wang yan <[email protected]>
wy65701436
added a commit
to wy65701436/harbor
that referenced
this pull request
Dec 4, 2024
* fix robot deletion event Signed-off-by: wang yan <[email protected]> * resolve comments Signed-off-by: wang yan <[email protected]> --------- Signed-off-by: wang yan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: