Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dedicated Note section instead of plain text #10052

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Use dedicated Note section instead of plain text #10052

wants to merge 2 commits into from
+6 −4

Conversation

dustdfg
Copy link
Contributor

@dustdfg dustdfg commented Oct 6, 2024

No description provided.

tetrapod00
tetrapod00 previously approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@tetrapod00 tetrapod00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm neutral on this change. I don't think it majorly improves readability to make every "Note that" a note block. But I'm not against it either.

tutorials/io/runtime_file_loading_and_saving.rst Outdated Show resolved Hide resolved
@dustdfg dustdfg marked this pull request as draft October 9, 2024 04:36
@tetrapod00 tetrapod00 added enhancement topic:audio area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Nov 15, 2024
@tetrapod00 tetrapod00 dismissed their stale review November 20, 2024 07:34

Original review was a gray check, not green; and the PR is marked as draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tetrapod00 tetrapod00 tetrapod00 left review comments

Assignees
No one assigned
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:audio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dustdfg @tetrapod00