Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update which requirement from 5 to 6 #1066

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 18, 2024

Updates the requirements on which to permit the latest version.

Release notes

Sourced from which's releases.

6.0.0

  • MSRV is now 1.70
  • Upgraded all dependencies to latest version
Changelog

Sourced from which's changelog.

6.0.0

  • MSRV is now 1.70
  • Upgraded all dependencies to latest version

5.0.0

  • Remove several unused error messages
  • Windows executables can now be found even if they don't have a '.exe' extension.
  • Add new error message, Error::CannotGetCurrentDirAndPathListEmpty

4.4.2

  • Remove dependency on dirs crate due to MPL licensing in its tree. Use home crate instead. (@​Xaeroxe)

4.4.1

Commits
  • fcde0ea Upgrade deps, move to 6.0.0
  • f50675a Prep 5.0.0 release
  • e776ff0 Return appropriate error if path list defined and empty
  • 70d2d1c Null terminate string for windows api
  • 5c6208b Change how unit test gets current exe
  • 6a027d1 Add unit test for extensionless Windows executable
  • See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [which](https://github.com/harryfei/which-rs) to permit the latest version.
- [Release notes](https://github.com/harryfei/which-rs/releases)
- [Changelog](https://github.com/harryfei/which-rs/blob/master/CHANGELOG.md)
- [Commits](harryfei/which-rs@5.0.0...6.0.0)

---
updated-dependencies:
- dependency-name: which
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies PRs updating dependencies (dependabot automation) label Jan 18, 2024
@GodotRust
Copy link

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdnative/pr-1066

@chitoyuu
Copy link
Contributor

While MSRV is usually bumped rather liberally, I'm not sure if it's desirable to do it for basically no reason. The current version of which already works very well and I can't see it being fundamentally improved upon in the future, so I'm ignoring this for now until concrete issues are found.

@dependabot ignore this dependency

@dependabot dependabot bot closed this Jan 20, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 20, 2024

OK, I won't notify you about which again, unless you re-open this PR.

@dependabot dependabot bot deleted the dependabot/cargo/which-6 branch January 20, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies PRs updating dependencies (dependabot automation)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants