Migrate crate-local /gen directories to OUT_DIR
#687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-687 |
|
Seems fine on VSCode (for Linux) using Rust-Analyzer extension (v0.4.1943) |
Bromeon
force-pushed
the
feature/output-dir
branch
from
7d166a9 to
e2711ab
Compare
|
VSCodium 1.87.2 on Linux (Flatpak version). Works out of the box. |
|
Works on Linux, VSCode + RustAnalyzer. Also tested whole build process and godot export on CI in |
Bromeon
force-pushed
the
feature/output-dir
branch
2 times, most recently
from
9d7de11 to
6d6c15c
Compare
|
Tested on VSCode 1.89 (windows) with Rust Analyzer v0.3.1950, and there were no issues. I would also like to note that I can confirm that this resolves some rust analyzer panic/warnings when compared with the master branch. |
Bromeon
force-pushed
the
feature/output-dir
branch
from
6d6c15c to
274dd2b
Compare
Remnant from times where the header regularly had breaking changes. Since Godot 4.1, changes should generally be backwards compatible. Some patching still happens in Rust code, with direct String::replace() calls.
Bromeon
force-pushed
the
feature/output-dir
branch
from
274dd2b to
977f925
Compare
|
Bringing this to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please help test this pull request on different IDEs. In the past, we experienced problems with static analysis and symbol completion when using
OUT_DIR.To try this PR, you can run
cargo clean, then replace yourgodotentry in Cargo.toml with this:Jetbrains
On Jetbrains IDEs, it may be necessary to run Cargo refresh:
Feedback
I'd appreciate if you could then respond here quickly with your IDE, its version and if things work (out of the box, or if a manual step like Cargo refresh is needed).
Closes #506.