Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check order no longer matters #307

Merged
merged 1 commit into from
Dec 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,12 @@ All documentation can be found on `dbt-bouncer` [documentation website](https://
pip install dbt-bouncer
```

1. `dbt-bouncer` requires a `manifest.json` file. If not already present, run:

```shell
dbt parse
```

1. Create a `dbt-bouncer.yml` config file:

```yml
Expand All @@ -81,11 +87,6 @@ All documentation can be found on `dbt-bouncer` [documentation website](https://
- name: check_model_names
include: ^models/staging
model_name_pattern: ^stg_
catalog_checks:
- name: check_columns_are_documented_in_public_models
run_results_checks:
- name: check_run_results_max_execution_time
max_execution_time_seconds: 60
```

1. Run `dbt-bouncer`:
Expand Down
6 changes: 1 addition & 5 deletions src/dbt_bouncer/config_file_validator.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,6 @@
- name: check_model_names
include: ^models/staging
model_name_pattern: ^stg_
catalog_checks:
- name: check_columns_are_documented_in_public_models
run_results_checks:
- name: check_run_results_max_execution_time
max_execution_time_seconds: 60
"""


Expand All @@ -50,6 +45,7 @@ def conf_cls_factory(
DbtBouncerConf: The configuration class.

"""
check_categories = sorted(check_categories)
if check_categories == ["catalog_checks"]:
from dbt_bouncer.config_file_parser import DbtBouncerConfCatalogOnly

Expand Down
2 changes: 0 additions & 2 deletions tests/unit/test_config_file_validator.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,6 @@ def test_load_config_file_contents_create_default_config_file(
)
assert list(contents.keys()) == [
"manifest_checks",
"catalog_checks",
"run_results_checks",
]


Expand Down