Improve i18n for table headers in the plugin settings #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have translated the plugin into Spanish and I realized that there is a small issue with the translation of the table headers in the plugin settings. Currently, the word 'Methods' is forced to be displayed at the end of the sentence, but in some languages, like Spanish, this doesn't make sense, and need to be moved to the start of the sentence:
This PR fix that: I have improved these headers, allowing the translator to move all the sentences parts if the language requires this. I also applied some small rewording, adding 'Shipping' word to make clear that the list shows shipping methods.
This is how the table headers looks in Spanish: