Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is being done in this PR?
Currently, having a bigint column in a fizz file causes the migration to fail against sqlite with an error like
could not call create_table function: can not use bigint as a primary key
, but actually sqlite supports 8 bytes integers in its INTEGER type.From the Sqlite docs:
Rails uses sqlite's integer as a subsititue for bigint in its schema convention:
What are the main choices made to get to this solution?
Rather than raising an error for bigint columns in sqlite, add an integer column, which supports 8 byte integer values.
List the manual test cases you've covered before sending this PR:
Using the soda CLI that's built with the changes in this PR, I ran a migration that creates a table with a bigint primary key in sqlite and another migration that adds a bigint column to an existing table.