Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): new color contrasts #429

Closed
wants to merge 1 commit into from
Closed

Conversation

biou
Copy link
Contributor

@biou biou commented Jul 26, 2020

related to #419

This is just a proposal. The idea is to have contrasts > 4.5:1 which is not currently the case. Currently people can have difficulties to see that there is a button and click on it.
For the hover/active state, instead of changing the color, we could also consider animating the dots.

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2020

Codecov Report

Merging #429 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #429   +/-   ##
=======================================
  Coverage   96.59%   96.59%           
=======================================
  Files           8        8           
  Lines         382      382           
  Branches       53       53           
=======================================
  Hits          369      369           
  Misses         13       13           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d6ffba...c5f4967. Read the comment docs.

@goblindegook
Copy link
Owner

I'd probably make this a breaking change (just add BREAKING CHANGE: before the commit description) since it would change button colours for current users who haven't customised/overridden their styles.

@biou
Copy link
Contributor Author

biou commented Aug 21, 2020

Anything I can do to improve this PR @goblindegook ?

@goblindegook
Copy link
Owner

Haven't forgotten about it. I was considering batching this with some other breaking changes, possibly an overhaul of the styles (which were left mostly unchanged from Bigfoot), dropping Sass and adding support for stuff like CSS variables.

@biou
Copy link
Contributor Author

biou commented Aug 22, 2020

No problem, sounds good!

@goblindegook
Copy link
Owner

Closing the PR because these files no longer exist. Changes will incorporate the feedback discussed in #419.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants