Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(exec): dereference outputs container config for executor setup #612

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Nov 1, 2024

This fixes an error where all executors try to share the outputs container config of whichever exec process last set it.

I'm also increasing the local stack build limit to 3 because this will help prevent future issues like this without sacrificing any sort of convenience for developers.

@ecrupper ecrupper requested a review from a team as a code owner November 1, 2024 17:29
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 62.02%. Comparing base (04b2f56) to head (43c4aad).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/vela-worker/exec.go 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #612      +/-   ##
==========================================
- Coverage   62.02%   62.02%   -0.01%     
==========================================
  Files         121      121              
  Lines        8172     8173       +1     
==========================================
  Hits         5069     5069              
- Misses       2877     2878       +1     
  Partials      226      226              
Files with missing lines Coverage Δ
cmd/vela-worker/exec.go 0.00% <0.00%> (ø)

@ecrupper ecrupper merged commit 402d3d0 into main Nov 1, 2024
10 of 12 checks passed
@ecrupper ecrupper deleted the fix/multi-exec-outputs branch November 1, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants