Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(init): display basic worker info in init step logs #510

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

ecrupper
Copy link
Contributor

Closes go-vela/community#125.

While we can leverage the hover display on the build nav bar to check the worker that ran a specific build, I've found this to be a bit finicky and more difficult to analyze older builds. Throwing some basic worker / runtime info in the init step seems like a fairly simple win.

I can also foresee this change being temporary if/when the init step overhaul proposal gets off the ground and running.

@ecrupper ecrupper requested a review from a team as a code owner September 19, 2023 14:36
@ecrupper ecrupper self-assigned this Sep 19, 2023
Copy link
Contributor

@plyr4 plyr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #510 (1cecf33) into main (bb0406d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #510      +/-   ##
==========================================
+ Coverage   83.42%   83.44%   +0.01%     
==========================================
  Files          69       69              
  Lines        5376     5381       +5     
==========================================
+ Hits         4485     4490       +5     
  Misses        746      746              
  Partials      145      145              
Files Changed Coverage Δ
executor/linux/build.go 77.05% <100.00%> (+0.22%) ⬆️

@ecrupper ecrupper merged commit dd23185 into main Sep 19, 2023
11 of 12 checks passed
@ecrupper ecrupper deleted the enhance/init/display-worker-info branch September 19, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow a way to display which worker and runtime a build ran on
3 participants